Fix the matrix representation of CUGate in Rust
#13121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matthew Treinish <[email protected]>
Cryoris
added
stable backport potential
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 10794415482Details
💛 - Coveralls |
mtreinish
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
I double checked: https://github.com/Qiskit/qiskit/blob/main/qiskit/circuit/library/standard_gates/u.py#L357-L375 and this is correct the angles were backwards in rust and we didn't catch it because the tests were using the same values for all the parameters.
mergify bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit 8929e12)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Co-authored-by: Matthew Treinish <[email protected]> (cherry picked from commit 8929e12) Co-authored-by: Julien Gacon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed #13118.
Details and comments
The matrix representation of
CUGatein Rust accidentally swapped two arguments (phiandlam). This didn't fail the tests, because there all parameters are set to the same value. The tests are therefore also updated to vary the parameters values within a gate.